Re: Add 64-bit XIDs into PostgreSQL 15
| От | Finnerty, Jim |
|---|---|
| Тема | Re: Add 64-bit XIDs into PostgreSQL 15 |
| Дата | |
| Msg-id | 6F7A244A-1CE4-4744-A305-92E6ADEDE2F4@amazon.com обсуждение исходный текст |
| Ответ на | Re: Add 64-bit XIDs into PostgreSQL 15 (Fujii Masao <masao.fujii@oss.nttdata.com>) |
| Список | pgsql-hackers |
Re: clog page numbers, as returned by TransactionIdToPage
- int pageno = TransactionIdToPage(xid); /* get page of parent */
+ int64 pageno = TransactionIdToPage(xid); /* get page of parent */
...
- int pageno = TransactionIdToPage(subxids[0]);
+ int64 pageno = TransactionIdToPage(subxids[0]);
int offset = 0;
int i = 0;
...
- int nextpageno;
+ int64 nextpageno;
Etc.
In all those places where you are replacing int with int64 for the kind of values returned by TransactionIdToPage(),
wouldyou mind replacing the int64's with a type name, such as ClogPageNumber, for improved code maintainability?
В списке pgsql-hackers по дате отправления: