Re: Review: Patch to compute Max LSN of Data Pages

Поиск
Список
Период
Сортировка
От Amit kapila
Тема Re: Review: Patch to compute Max LSN of Data Pages
Дата
Msg-id 6C0B27F7206C9E4CA54AE035729E9C383BEB8A75@szxeml509-mbx
обсуждение исходный текст
Ответ на Review: Patch to compute Max LSN of Data Pages  (Muhammad Usama <m.usama@gmail.com>)
Ответы Re: Review: Patch to compute Max LSN of Data Pages  ("Dickson S. Guedes" <listas@guedesoft.net>)
Список pgsql-hackers

Please find the rebased Patch for Compute MAX LSN.

 

There was one compilation error as "undefined reference to XLByteLT " as earlier  XLogRecPtr was a structure as
                        typedef struct XLogRecPtr
                        {
                                uint32                xlogid;                        /* log file #, 0 based */
                                uint32                xrecoff;                /* byte offset of location in log file */
                        } XLogRecPtr;
So in order to compare two LSN, there was one macro as XLByteLT to compare both fields.
But now XLogRecPtr  has been changed as just uint64 and so XLByteLT is removed.
So the change done is to replace XLByteLT(*maxlsn, pagelsn) with (*maxlsn < pagelsn).

Muhammad, Can you verify if every thing is okay, then this can be marked as "Ready for Committer"

 

With Regards,

Amit Kapila.

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Stephen Frost
Дата:
Сообщение: Re: could not create directory "...": File exists
Следующее
От: Amit Kapila
Дата:
Сообщение: Re: Passing connection string to pg_basebackup