Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance tweak

Поиск
Список
Период
Сортировка
От Magnus Hagander
Тема Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance tweak
Дата
Msg-id 6BCB9D8A16AC4241919521715F4D8BCE92E764@algol.sollentuna.se
обсуждение исходный текст
Ответы Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance tweak  (Qingqing Zhou <zhouqq@cs.toronto.edu>)
Список pgsql-hackers
> > Shall we add "volatile" quanlifier to at least pg_signal_queue?
>
> If that's changed by a separate thread, "volatile" seems essential.
> What about the mask variable?

Yes, that does seem right. Previously it would never be concurrently
modified, because it was always locked by the critical section, but now
we read it without locking, and we certainly don't want that optimized
away.

The mask is only ever written by the main thread, never by the signal
dispatching thread. So I think that one could do without.

//Magnus


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Andrew Dunstan
Дата:
Сообщение: Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance
Следующее
От: "Merlin Moncure"
Дата:
Сообщение: Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance tweak