Re: No error checking when reading from file using zstd in pg_dump

Поиск
Список
Период
Сортировка
От Daniel Gustafsson
Тема Re: No error checking when reading from file using zstd in pg_dump
Дата
Msg-id 69A4E455-94E6-4348-9007-D7CCBA0E2D40@yesql.se
обсуждение исходный текст
Ответ на Re: No error checking when reading from file using zstd in pg_dump  (Evgeniy Gorbanev <gorbanyoves@basealt.ru>)
Ответы Re: No error checking when reading from file using zstd in pg_dump
Re: No error checking when reading from file using zstd in pg_dump
Список pgsql-hackers
> On 26 Jun 2025, at 20:01, Daniel Gustafsson <daniel@yesql.se> wrote:
>
>> On 26 Jun 2025, at 15:33, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
>> So on the whole I prefer the "void" approach.  I'm not dead
>> set on that though, it's just a niggling worry.
>
> I think the likelyhood of it being a problem in practice is pretty slim, but
> it's still a stronger argument than my "match an API we're still not aligned
> with". The attached v7 reverts back to void return.

In preparing for concluding this I've attached a v8 which is the patchset in v7
squashed into a single commit with an attempt at a commit message.

This version has been tested against v17 and v16 where it applies and passes
all tests (the latter isn't as assuring as it should be since there is a lack
of testcoverage).

--
Daniel Gustafsson


Вложения

В списке pgsql-hackers по дате отправления: