Re: Adding REPACK [concurrently]

Поиск
Список
Период
Сортировка
От Antonin Houska
Тема Re: Adding REPACK [concurrently]
Дата
Msg-id 68571.1772737573@localhost
обсуждение исходный текст
Ответ на Re: Adding REPACK [concurrently]  (Antonin Houska <ah@cybertec.at>)
Ответы Re: Adding REPACK [concurrently]
Список pgsql-hackers
Antonin Houska <ah@cybertec.at> wrote:

> Antonin Houska <ah@cybertec.at> wrote:
> 
> > Mihail Nikalayeu <mihailnikalayeu@gmail.com> wrote:
> > > ------------
> > > 
> > > > attrs = palloc0_array(Datum, desc->natts);
> > > > isnull = palloc0_array(bool, desc->natts);
> > > 
> > > It looks like there is a memory leak with those arrays.
> > 
> > I suppose you mean store_change(). Yes, I tried to free the individual chunks
> > and forgot these. The next version uses a new, per-change memory context.
> 
> I realize now that I forgot to reset the context at the end of the
> function. I'll fix that in the next version (which will probably be posted
> rather soon).

This is it. One more diff added, to engage BulkInsertState.

-- 
Antonin Houska
Web: https://www.cybertec-postgresql.com


Вложения

В списке pgsql-hackers по дате отправления: