Re: postgresql.conf: patch to have ParseConfigFile report all parsing errors, then bail

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: postgresql.conf: patch to have ParseConfigFile report all parsing errors, then bail
Дата
Msg-id 6830.1236561266@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: postgresql.conf: patch to have ParseConfigFile report all parsing errors, then bail  (Alvaro Herrera <alvherre@commandprompt.com>)
Список pgsql-hackers
Alvaro Herrera <alvherre@commandprompt.com> writes:
> Not that this has anything to do with the patch at hand, but I remember
> thinking about this sort of error message in the past.  Would it be
> appropriate to move the file name and line number to an errcontext()
> field?

I think the message is fine as is.  If you moved that information then
you'd have nothing left in the base message but "syntax error", which
is useless.

> I know somebody is going to say "but errcontext is not shown when
> verbosity is set to terse", to which I say that we should fix that too.

No, because the whole point of terse is to be terse.  Adding context
to the output would just create a demand for "super terse" mode.
        regards, tom lane


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Andrew Dunstan
Дата:
Сообщение: Re: small parallel restore optimization
Следующее
От: Tom Lane
Дата:
Сообщение: Re: small parallel restore optimization