On 06/18/2018 01:31 PM, Andres Freund wrote:
> On 2018-06-18 13:21:43 -0400, Alvaro Herrera wrote:
>> On 2018-Jun-17, Peter Geoghegan wrote:
>>
>>> On Sat, Jun 16, 2018 at 8:51 PM, Alvaro Herrera
>>> <alvherre@2ndquadrant.com> wrote:
>>>> I don't necessarily object to the proposed change, but I think you
>>>> should generally wait a bit longer for others to react.
>>> What wait period do you think is appropriate in this case?
>> One which includes at least half a working day in a different timezone.
>> You asked mid-afternoon on a Friday in a timezone pretty far west. I
>> think you could find people in their offices in Easter Island, but not
>> many more.
> I think there's also a question of how much a patch is blocking you /
> others. A shorter question period is more understandable if it's step
> 3/40, rather than 1/1...
>
Yeah, but this would still apply for the first in a series of advertised
patches.
I usually try to wait at least a couple of days. I'm sure every
committer understands how you can feel the itch to push. I know I do.
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services