Re: Patch: add conversion from pg_wchar to multibyte

Robert Haas <robertmhaas@gmail.com> writes:
> On Thu, Jul 5, 2012 at 7:11 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Hm, several of these routines seem to neglect to advance the "from"
>> pointer?

> Err... yeah.  That's not a bug I introduced, but I should have caught
> it... and it does make me wonder how well this code was tested.

> Does the attached look like an appropriate fix?

I'd be inclined to put the from++ and len-- at the bottom of each loop,
and in that order every time, just for consistency and obviousness.
But yeah, that's basically what's needed.
        regards, tom lane