On 9/28/16 10:48 PM, Thomas Munro wrote:
> I wonder if the following bit of gin.h should be more nuanced: maybe
> it's OK to convert between bool and GinTernaryValue, but it's
> definitely not OK to cast between pointers types? Or maybe we should
> have a function/macro to convert between the types explicitly and not
> encourage people to consider them convertible.
The more I look into the this, the more this looks like a web of lies.
:-) The GIN consistent and triconsistent functions randomly change
around between bool and GinTernaryValue, share some of the same data
structures, and there is little guarantee that they each get the right
kind of value all the time. This could perhaps use some deeper cleaning
at some point. I've left that alone for now.
>> 0009-Rename-some-typedefs-to-avoid-name-conflicts.patch
>
> I don't know if it's a relevant precedent or not, but I noticed that
> fdwapi.h, amapi.h and tsmapi.h used the convention that function
> pointer types are named XXX_function, and then the members of a struct
> behaving as a kind of vtable are named XXX.
Good idea, and that also overlaps with some other stuff I have wanted to
tidy up in pg_dump, so I might get back to that later.
>> 0011-Add-missing-fields-in-struct-initializations.patch
>
> I don't undestand why this is necessary, unless you're explicitly
> choosing to enable a warning like missing-field-initializers for C++
> but not for C.
I can't reproduce this anymore, so never mind.
> As for the commitfest entry: this thread discusses two different
> people's efforts to compile PostgreSQL as C++. Joy Arulraj's github
> branch derives in some way from Peter Eisentraut's work, but I have
> provided feedback on Peter's patches, because (1) they were posted
> here in patch format and (2) there is a commitfest entry listening
> Peter as the author. I think several of these patches are
> committable, and many obviously are not. Heikki already set the CF
> item to 'Ready for Committer' based on an inspection of a few of the
> patches, but invited others to continue looking, so I did.
Yeah, I have committed a few of the patches now and I'll close the CF
entry now. Thanks for your research.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services