Re: SRF memory leaks

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: SRF memory leaks
Дата
Msg-id 6684.1204142845@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: SRF memory leaks  (Neil Conway <neilc@samurai.com>)
Ответы Re: SRF memory leaks  (Neil Conway <neilc@samurai.com>)
Список pgsql-patches
Neil Conway <neilc@samurai.com> writes:
> On Tue, 2008-02-26 at 00:17 -0800, Neil Conway wrote:
>> You didn't comment on my proposed solution (FreeTupleDesc() iff refcount
>> == -1).

I still find that entirely unsafe, particularly for something you
propose to back-patch into stable branches.  Negative refcount does
not prove that the SRF itself hasn't still got a pointer to the tupdesc.

Can't we fix it so that the tupdesc is allocated in the new special
context (at least in the primary code paths), and then no explicit
free is needed?

            regards, tom lane

В списке pgsql-patches по дате отправления:

Предыдущее
От: Neil Conway
Дата:
Сообщение: Re: SRF memory leaks
Следующее
От: Neil Conway
Дата:
Сообщение: Re: SRF memory leaks