Re: pgsql: Add sql_drop event for event triggers

Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> Add sql_drop event for event triggers

The buildfarm members that use -DCLOBBER_CACHE_ALWAYS don't like this
patch:

***************
*** 760,771 ****
      FROM generate_series(1, 50) a;
  BEGIN;
  SET TRANSACTION ISOLATION LEVEL SERIALIZABLE;
  UPDATE serializable_update_tab SET description = 'no no', id = 1 WHERE id = 1;
  COMMIT;
  SELECT description FROM serializable_update_tab WHERE id = 1;
!     description
! --------------------
!  updated in trigger
  (1 row)

  DROP TABLE serializable_update_tab;
--- 760,773 ----
      FROM generate_series(1, 50) a;
  BEGIN;
  SET TRANSACTION ISOLATION LEVEL SERIALIZABLE;
+ ERROR:  SET TRANSACTION ISOLATION LEVEL must be called before any query
  UPDATE serializable_update_tab SET description = 'no no', id = 1 WHERE id = 1;
+ ERROR:  current transaction is aborted, commands ignored until end of transaction block
  COMMIT;
  SELECT description FROM serializable_update_tab WHERE id = 1;
!  description
! -------------
!  new
  (1 row)

  DROP TABLE serializable_update_tab;

I suspect you have inserted a snapshot-capturing operation into
someplace it mustn't go during transaction startup, but only in a path
that is triggered by an immediately preceding cache flush.

            regards, tom lane