Re: remove useless comments
| От | Tom Lane |
|---|---|
| Тема | Re: remove useless comments |
| Дата | |
| Msg-id | 6587.1660060243@sss.pgh.pa.us обсуждение |
| Ответ на | remove useless comments (Junwang Zhao <zhjwpku@gmail.com>) |
| Ответы |
Re: remove useless comments
|
| Список | pgsql-hackers |
Junwang Zhao <zhjwpku@gmail.com> writes:
> The comments considering checking share/ directory was there for
> almost 13 years, yet nobody ever trying to add the checking, and
> there seems never any trouble for not checking it, then I think
> we should remove those comments.
I think that comment is valuable. It shows that checking the
sibling directories was considered and didn't seem worthwhile.
Perhaps it should be rephrased in a more positive way (without XXX),
but merely deleting it is a net negative because future hackers
would have to reconstruct that reasoning.
BTW, we're working in a 30+-year-old code base, so the mere fact
that a comment has been there a long time does not make it bad.
regards, tom lane
В списке pgsql-hackers по дате отправления: