Alvaro Herrera <alvherre@2ndquadrant.com> writes:
>> On Mon, Jan 13, 2020 at 7:52 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> Isn't the change in the TAP test output sufficient?
> Yeah, I think there should be at least one regexp in t/002_pg_dump.pl to
> verify ALTER FOREIGN TABLE is being produced.
> I wonder if Tom is thinking about Luis' other pg_dump patch for foreign
> tables, which includes some changes to src/test/modules/test_pg_dump.
No, I was just reacting to the comment that the TAP test was failing,
and assuming that that meant the patch had already changed the expected
output. Looking at the patch now, I suppose that just means it had
incautiously changed whitespace or something for the non-foreign case.
I can't get terribly excited about persuading that test to cover this
trivial little bit of logic, but if you are, I won't stand in the way.
regards, tom lane