Re: NDirectFileRead and Write

ITAGAKI Takahiro <itagaki.takahiro@oss.ntt.co.jp> writes:
> Here is a patch to user NDirectFileRead/Write counters to get I/O counts
> in BufFile module. We can see the counters when log_statement_stats is on.

Couple thoughts here:

* Let's rename them BufFileReadCount and BufFileWriteCount to reflect
their actual purpose.

* If the extern's are moved to buffile.h, I think the definitions of the
variables themselves should move to buffile.c.  However, that would
imply including buffile.h in bufmgr.c which is a bit ugly from a
modularity standpoint.  In any case I agree that the current arrangement
with execdebug.h declaring variables defined in bufmgr.c is just weird.
        regards, tom lane