On 11/26/21 15:14, Daniel Gustafsson wrote:
>> On 26 Nov 2021, at 20:33, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>
>> I think our policy is to suppress unused-variable warnings if they
>> appear on current mainstream compilers; and it feels a little churlish
>> to deem MSVC non-mainstream. So I stick with my previous suggestion,
>> which basically was to disable C4101 until such time as somebody can
>> make PG_USED_FOR_ASSERTS_ONLY work correctly on MSVC. In the worst
>> case, that might lead a Windows-based developer to submit a patch that
>> draws warnings elsewhere ... but the cfbot, other developers, or the
>> buildfarm will find such problems soon enough.
> I agree with that, and can go make that happen.
>
[trust I have attributions right]
ISTM the worst case is that there will be undetected unused variables in
Windows-only code. I guess that would mostly be detected by Msys systems
running gcc.
Anyway I don't think it's worth arguing a lot about.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com