Re: compute_query_id and pg_stat_statements

Поиск
Список
Период
Сортировка
От Fujii Masao
Тема Re: compute_query_id and pg_stat_statements
Дата
Msg-id 63caca55-a48b-a8b4-9c17-814a7106e035@oss.nttdata.com
обсуждение исходный текст
Ответ на Re: compute_query_id and pg_stat_statements  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Ответы Re: compute_query_id and pg_stat_statements  (Julien Rouhaud <rjuju123@gmail.com>)
Список pgsql-hackers

On 2021/05/14 9:04, Alvaro Herrera wrote:
> Here's a first attempt at what was suggested.  If you say "auto" it
> remains auto in SHOW, but it gets enabled if a module asks for it.
> 
> Not final yet, but I thought I'd throw it out for early commentary ...

Many thanks! The patch basically looks good to me.

+void
+EnableQueryId(void)
+{
+    if (compute_query_id == COMPUTE_QUERY_ID_AUTO)
+        auto_query_id_enabled = true;

Shouldn't EnableQueryId() enable auto_query_id_enabled whatever compute_query_id is?
Otherwise, for example, the following scenario can happen and it's a bit strange.

1. The server starts up with shared_preload_libraries=pg_stat_statements and compute_query_id=on
2. compute_query_id is set to auto and the configuration file is reloaded
Then, even though compute_query_id is auto and pg_stat_statements is loaded,
query ids are not computed and no queries are tracked by pg_stat_statements.


Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Peter Geoghegan
Дата:
Сообщение: Re: Teaching users how they can get the most out of HOT in Postgres 14
Следующее
От: Julien Rouhaud
Дата:
Сообщение: Re: compute_query_id and pg_stat_statements