> On 21 May 2023, at 19:17, Anton Kirilov <antonvkirilov@gmail.com> wrote:
> .. here is an updated version of the patch
This hunk here:
- if (PQflush(conn) < 0)
+ const int ret = flags & PG_PIPELINEPUTSYNC_FLUSH ? PQflush(conn) : 0;
+
+ if (ret < 0)
..is causing this compiler warning:
fe-exec.c: In function ‘PQpipelinePutSync’:
fe-exec.c:3203:2: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
3203 | const int ret = flags & PG_PIPELINEPUTSYNC_FLUSH ? PQflush(conn) : 0;
| ^~~~~
cc1: all warnings being treated as errors
Also, the patch no longer applies. Please rebase and send an updated version.
--
Daniel Gustafsson