Re: refactoring basebackup.c

Поиск
Список
Период
Сортировка
От Mark Dilger
Тема Re: refactoring basebackup.c
Дата
Msg-id 6300965F-E30F-41F4-9785-A49EA725ECD8@enterprisedb.com
обсуждение исходный текст
Ответ на Re: refactoring basebackup.c  (Robert Haas <robertmhaas@gmail.com>)
Ответы Re: refactoring basebackup.c
Список pgsql-hackers

> On Jul 21, 2021, at 8:09 AM, Robert Haas <robertmhaas@gmail.com> wrote:
>
> A callback where?

If you were going to support lots of formats, not just tar, you might want the streamer class for each format to have a
callbackwhich sets up the injector, rather than having CreateBackupStreamer do it directly.  Even then, having now
studiedCreateBackupStreamer a bit more, the idea seems less appealing than it did initially.  I don't think it makes
thingsany cleaner when only supporting tar, and maybe not even when supporting multiple formats, so I'll withdraw the
suggestion.

—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company






В списке pgsql-hackers по дате отправления:

Предыдущее
От: Jacob Champion
Дата:
Сообщение: Re: badly calculated width of emoji in psql
Следующее
От: Vladimir Sitnikov
Дата:
Сообщение: Re: speed up verifying UTF-8