Re: tuplesort.c's copytup_index() is dead code

Peter Geoghegan <pg@heroku.com> writes:
> Commit 9f03ca915 removed the only COPYTUP() call that could reach
> copytup_index() in practice, making copytup_index() dead code.

> The attached patch removes this dead code,

I think this may be premature in view of bug #14210.  Even if we
don't reinstate use of this function to fix that, I'm not really
convinced we want to get rid of it; it seems likely to me that
we might want it again.
        regards, tom lane