On 09.03.22 17:44, Andres Freund wrote:
>> v6-0009-prereq-make-unicode-targets-work-in-vpath-builds.patch.gz
>>
>> Another directory issue
> I think it's a tad different, in that it's fixing something that's currently
> broken in VPATH builds.
Ok, I took another look at this.
-override CPPFLAGS := -DFRONTEND $(CPPFLAGS)
+override CPPFLAGS := -DFRONTEND
-I$(abs_top_builddir)/src/common/unicode $(CPPFLAGS)
This could just be
-I.
- $(PERL) generate-unicode_norm_table.pl
+ $(PERL) $< $(CURDIR)
I didn't detect a need for the additional directory argument. (So the
changes in generate-unicode_norm_table.pl are also apparently not
necessary.) Maybe this is something that will become useful later, in
which case it should be split out from this patch.
The rest of this patch looks ok.