On Fri, Mar 27, 2009 at 11:42 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> and the first two items from the "questions" category, which
>> don't seem important enough to worry about at this stage of the game.
>
> Both of those things are related to 8.4 feature changes, so we should
> either do them now or decide we won't do them.
Well, "Should we have a LOCALE option in CREATE DATABASE?" has to do
with making:
CREATE DATABASE foo WITH LOCALE = bar
equivalent to...
CREATE DATABASE foo WITH COLLATE = bar, CTYPE = bar
That might be nice to have, but since it's just syntactic sugar, I
disagree that it's now or never.
The second item, "Should we reject toast.fillfactor in reloptions?",
comes with a patch. I think I agree with ITAGAKI Takahiro that it
would be better to have reloptions specify a set of RELOPT_KINDs to
which they pertain rather than a single one. There are likely to be
other types of reloptions that could apply to more than one category
of objects, and duplicating the definitions is not a desirable coping
strategy. So I guess I'm in favor of applying this patch if others
are satisfied with the quality of the code (which I have looked at,
but only briefly). Given the fact that anyone who understands both
toast and fillfactor should know that they don't make sense together
(and we can also document this), I don't think too many people will
get bitten if we ignored this issue for 8.4 and then applied the patch
to 8.5, but since the code is already written, there may be no reason
to take the risk.
...Robert