Re: Fix hints on CREATE PROCEDURE errors

Поиск
Список
Период
Сортировка
От Amit Langote
Тема Re: Fix hints on CREATE PROCEDURE errors
Дата
Msg-id 5cab5d96-aaff-3140-7666-b8f3a520087e@lab.ntt.co.jp
обсуждение исходный текст
Ответ на Fix hints on CREATE PROCEDURE errors  (Jeremy Evans <code@jeremyevans.net>)
Список pgsql-hackers
Hi.

On 2018/08/07 3:32, Jeremy Evans wrote:
> When testing out CREATE PROCEDURE with 11 beta 2, I noticed, the hints
> in the errors reference DROP FUNCTION, which doesn't work for
> procedures.

Good catch.

> DROP ROUTINE works for both functions and procedures, so
> this patch should work for both.

Not sure if we should fix it the way your patch does, but it seems you
forgot to include changes to the expected output of some of the regression
tests affected by this patch.  Attached updated patch includes those.

Thanks,
Amit

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Amit Langote
Дата:
Сообщение: Re: partition tree inspection functions
Следующее
От: Robert Haas
Дата:
Сообщение: Re: Negotiating the SCRAM channel binding type