Re: pgsql: Refactor COPY FROM to use format callback functions.

Поиск
Список
Период
Сортировка
От Andrew Dunstan
Тема Re: pgsql: Refactor COPY FROM to use format callback functions.
Дата
Msg-id 5c7e1ac8-5083-4c08-af19-cb9ade2f16ce@dunslane.net
обсуждение исходный текст
Ответ на pgsql: Refactor COPY FROM to use format callback functions.  (Masahiko Sawada <msawada@postgresql.org>)
Ответы Re: pgsql: Refactor COPY FROM to use format callback functions.
Список pgsql-committers


On 2025-02-28 Fr 1:31 PM, Masahiko Sawada wrote:
Refactor COPY FROM to use format callback functions.

This commit introduces a new CopyFromRoutine struct, which is a set of
callback routines to read tuples in a specific format. It also makes
COPY FROM with the existing formats (text, CSV, and binary) utilize
these format callbacks.

This change is a preliminary step towards making the COPY FROM command
extensible in terms of input formats.

Similar to 2e4127b6d2d, this refactoring contributes to a performance
improvement by reducing the number of "if" branches that need to be
checked on a per-row basis when sending field representations in text
or CSV mode. The performance benchmark results showed ~5% performance
gain in text or CSV mode.

Author: Sutou Kouhei <kou@clear-code.com>
Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com>
Reviewed-by: Michael Paquier <michael@paquier.xyz>
Reviewed-by: Andres Freund <andres@anarazel.de>
Reviewed-by: Tomas Vondra <tomas.vondra@enterprisedb.com>
Reviewed-by: Junwang Zhao <zhjwpku@gmail.com>
Discussion: https://postgr.es/m/20231204.153548.2126325458835528809.kou@clear-code.com



This patch has completely broken the file_textarray fdw, which uses NextCopyFromRawFields(). Removing that from API is not a good thing.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

В списке pgsql-committers по дате отправления: