Re: POC: make mxidoff 64 bits

Поиск
Список
Период
Сортировка
От Heikki Linnakangas
Тема Re: POC: make mxidoff 64 bits
Дата
Msg-id 5b4e458d-94f1-4ca3-ab72-aae8328e038d@iki.fi
обсуждение
Ответ на Re: POC: make mxidoff 64 bits  (Maxim Orlov <orlovmg@gmail.com>)
Список pgsql-hackers
On 20/02/2026 10:47, Maxim Orlov wrote:
> 
> Just one more minor thing. While working on making CLOG 64-bit, I
> noticed that read error messages from SLRU pages were reported only in
> 32-bit format, with the upper half simply truncated. Here's a small
> patch to fix this problem. I used the "%u:%u" format because it is
> already used by Postgres for outputting 64-bit transactions.

Hmm, that's a prettya misleading format for multixid member offsets. And 
for CLOG and other SLRUs too, as they will always show the epoch as 0.

This isn't really a new issue though, the SLRU errors have always said 
"transaction %u", even for multixids and offsets, and that's always been 
a little bogus. And for the pg_async SLRU, we just pass 
InvalidTransactionId.

Can we improve the message with a callback or something, so that it's 
more relevant for the SLRU?

- Heikki




В списке pgsql-hackers по дате отправления: