Re: [review] PostgreSQL Service on Windows does not start if data directory given is relative path

Поиск
Список
Период
Сортировка
Искать
От
MauMau
Тема
Re: [review] PostgreSQL Service on Windows does not start if data directory given is relative path
Дата
Msg-id
5A2F76FFC45F48A4BA5B2725231963CC@maumau
Ответ на
Список
Дерево обсуждения
[review] PostgreSQL Service on Windows does not start if data directory given is relative path "MauMau" <maumau307@gmail.com>
Re: [review] PostgreSQL Service on Windows does not start if data directory given is relative path Rajeev rastogi <rajeev.rastogi@huawei.com>
Re: [review] PostgreSQL Service on Windows does not start if data directory given is relative path "MauMau" <maumau307@gmail.com>
Re: [review] PostgreSQL Service on Windows does not start if data directory given is relative path Rajeev rastogi <rajeev.rastogi@huawei.com>
Re: [review] PostgreSQL Service on Windows does not start if data directory given is relative path "MauMau" <maumau307@gmail.com>
Re: [review] PostgreSQL Service on Windows does not start if data directory given is relative path Magnus Hagander <magnus@hagander.net>
Re: [review] PostgreSQL Service on Windows does not start if data directory given is relative path "MauMau" <maumau307@gmail.com>
Re: [review] PostgreSQL Service on Windows does not start if data directory given is relative path Rajeev rastogi <rajeev.rastogi@huawei.com>
Re: [review] PostgreSQL Service on Windows does not start if data directory given is relative path "MauMau" <maumau307@gmail.com>
Re: [review] PostgreSQL Service on Windows does not start if data directory given is relative path Rajeev rastogi <rajeev.rastogi@huawei.com>
Re: [review] PostgreSQL Service on Windows does not start if data directory given is relative path Tom Lane <tgl@sss.pgh.pa.us>
Re: [review] PostgreSQL Service on Windows does not start if data directory given is relative path Rajeev rastogi <rajeev.rastogi@huawei.com>
Re: [review] PostgreSQL Service on Windows does not start if data directory given is relative path "MauMau" <maumau307@gmail.com>
Re: [review] PostgreSQL Service on Windows does not start if data directory given is relative path Rajeev rastogi <rajeev.rastogi@huawei.com>
From: "Rajeev rastogi" 
> Please find the attached revised patch.

Thanks, your patch looks good.  I confirmed the following:

* Applied cleanly to the latest source tree, and built on Linux and Windows 
(with MSVC) without any warnings.

* Changed to D:\ and ran "pg_ctl register -N pg -D pgdata", and checked the 
registry value ImagePath with regedit.  It contained -D "D:\pgdata".

* Changed to D:\pgdata and ran "pg_ctl register -N pg -D ..\pgdata", and 
checked the registry value ImagePath with regedit.  It contained -D 
"D:\pgdata".


Finally, please change the function description comment of 
get_absolute_path() so that the style follows other function in path.c. 
That is:

/** ** Function description*/

Then update the CommitFest entry with the latest patch and let me know of 
that.  Then, I'll change the patch status to ready for committer.

Regards
MauMau



В списке pgsql-hackers по дате отправления
От: Dave Page
Дата:
Сообщение: Re: narwhal and PGDLLIMPORT
От: Rajeev rastogi
Дата:
FAQ