Re: use rotate macro in more places

John Naylor <john.naylor@enterprisedb.com> writes:
> We've accumulated a few bit-twiddling hacks to get the compiler to
> emit a rotate instruction. Since we have a macro for that, let's use
> it, as in the attached. I thought the new call sites would look better
> with a "left" version, so I added a new macro for that. That's not
> necessary, however.

+1 --- I didn't look to see if you missed any spots, but this is
good as far as it goes.

> Some comments now look a bit too obvious to keep around, but maybe
> they should be replaced with a "why", instead of a "what":

Yeah.  Maybe like "combine successive hashkeys by rotating"?

            regards, tom lane