Thanks for your quick response, Fabien
> I think that PGPASSFILE is somehow checked twice
yup, that was unintended redundancy...
> I would suggest that the struct gets the value (from option,
> environment or default) and is always used elsewhere. The
> getPgPassFilename function should disappear and PasswordFromFile
> should be simplified significantly.
I agree, however that's easier said than done because the "default" is
only constant by its definition, not by its location.
There is no "default" location as the home directory depends not only on
the system but also on the user. Afaics we can't entirely get rid of a
function to get the location of the default .pgpass file.
Kind regards,
Julian