Re: bug in SignalSomeChildren

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: bug in SignalSomeChildren
Дата
Msg-id 579.1292602337@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: bug in SignalSomeChildren  (Robert Haas <robertmhaas@gmail.com>)
Список pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> On Fri, Dec 17, 2010 at 10:27 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I'm not really thrilled at the idea of calling
>> IsPostmasterChildWalSender for every child whether or not it will have
>> any impact on the decision. �That involves touching shared memory which
>> can be rather expensive (see previous discussions about shared cache
>> lines and so forth).

> The existing code already does that, unless I'm missing something.

No, it only makes that call when it's actually relevant to the decision
and it's exhausted all other possible tests.  In particular, the call is
never made for target = ALL which I think is the common case.
        regards, tom lane


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Alvaro Herrera
Дата:
Сообщение: Re: bug in SignalSomeChildren
Следующее
От: Robert Haas
Дата:
Сообщение: Re: [COMMITTERS] pgsql: Reset 'ps' display just once when resolving VXID conflicts.