Re: [PATCH] "could not reattach to shared memory" on Windows

Hello,

Thank you for correcting patch.
However, I think the following block have to use VirualFree*Ex*().

(yes, this should never happen, maybe there is actually no problem.but for logical correctness)

>+     if (address != UsedShmemSegAddr)
>+     {
>+         /*
>+          * Should never happen - in theory if allocation granularity causes strange
>+          * effects it could, so check just in case.
>+          *
>+          * Don't use FATAL since we're running in the postmaster.
>+          */
>+         elog(LOG, "reserved shared memory region got incorrect address %p, expected %p",
>+              address, UsedShmemSegAddr);
>+         VirtualFree(address, 0, MEM_RELEASE);    VirtualFreeEx(hChild, address, 0, MEM_RELEASE);

>+         return false;
>+     }

Regards,

-- 
Tsutomu Yamada
SRA OSS, Inc. Japan