Re: Optimization for updating foreign tables in Postgres FDW

On 2016/04/11 12:30, Michael Paquier wrote:
> +                       if ((cancel = PQgetCancel(entry->conn)))
> +                       {
> +                           PQcancel(cancel, errbuf, sizeof(errbuf));
> +                           PQfreeCancel(cancel);
> +                       }
> Wouldn't it be better to issue a WARNING here if PQcancel does not succeed?

Seems like a good idea.  Attached is an updated version of the patch.

Thanks for the review!

Best regards,
Etsuro Fujita