Re: Refectoring of receivelog.c

On 03/11/2016 11:15 AM, Magnus Hagander wrote:
>
...
>
>
> Pushed with updated comments and a named stsruct.

Pretty sure this memset call in pg_basebackup.c is incorrect, as it 
passes parameters in the wrong order:
    MemSet(&stream, sizeof(stream), 0);

It seems benign, because we're setting all the fields explicitly, but 
gcc is nagging about it.

regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services