Re: Confusing with commit time usage in logical decoding

Hello, Andres

You have introduced a large replication progress tracking infrastructure
last year. And there is a problem described at the link in the quote below.

Attached patch fix this issue. Is this patch correct? I will be grateful
if it is and if it will be committed.

Thanks.

On 29.02.2016 14:18, Artur Zakirov wrote:
> Hello,
>
> I read this message
> http://www.postgresql.org/message-id/56D4197E.9050706@informatik.uni-kl.de
>
> Is this a bug or a typo? In DecodeCommit() in decode.c instead of:
>
> if (parsed->xinfo & XACT_XINFO_HAS_ORIGIN)
> {
>      origin_lsn = parsed->origin_lsn;
>      commit_time = parsed->origin_timestamp;
> }
>
> should be:
>
> if (parsed->xinfo & XACT_XINFO_HAS_ORIGIN)
> {
>      origin_lsn = parsed->origin_lsn;
>      commit_time = parsed->origin_timestamp;
> }
> else
>      commit_time = parsed->xact_time;
>


--
Artur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company