> On 25 Apr 2024, at 05:49, Michael Paquier <michael@paquier.xyz> wrote:
>
> On Wed, Apr 24, 2024 at 01:31:12PM +0200, Daniel Gustafsson wrote:
>> Done. Attached are the two remaining patches, rebased over HEAD, for removing
>> support for OpenSSL 1.0.2 in v18. Parking them in the commitfest for now.
>
> You have mentioned once upthread the documentation of PQinitOpenSSL():
> However, this is unnecessary when using <productname>OpenSSL</productname>
> version 1.1.0 or later, as duplicate initializations are no longer problematic.
>
> With 1.0.2's removal in place, this could be simplified more and the
> patch does not touch it. This relates also to pq_init_crypto_lib,
> which is gone with 0001. Of course, it is not possible to just remove
> PQinitOpenSSL() or old application may fail linking. Removing
> pq_init_crypto_lib reduces any confusion around this part of the
> initialization.
That's a good point, there is potential for more code removal here. The
attached 0001 takes a stab at it while it's fresh in mind, I'll revisit before
the July CF to see if there is more that can be done.
--
Daniel Gustafsson