On 2016/01/28 18:15, Alvaro Herrera wrote:
> Etsuro Fujita wrote:
>> On 2016/01/28 12:13, Robert Haas wrote:
>>> I don't think this is a good idea. Most of the time, no system
>>> columns will be present, and we'll just be scanning the Bitmapset
>>> twice rather than once. Sure, that doesn't take many extra cycles,
>>> but if the point of all this is to micro-optimize this code, that
>>> particular change is going in the wrong direction.
>> I thought that is a good idea, considering the additional overhead is
>> little, because that would be useful for some use-cases. But I think we
>> need more discussions about that, so if there are no objections from Alvaro
>> (or anyone), I'll leave that part as-is.
> I'm happy to defer.
Done. Attached is an updated version of the patch.
Best regards,
Etsuro Fujita