[PATCH] pg_ctl should not truncate command lines at 1024 characters
От
Phil Krylov
Тема
[PATCH] pg_ctl should not truncate command lines at 1024 characters
Дата
Msg-id
567e199c6b97ee19deee600311515b86@krylov.eu
Список
Дерево обсуждения
[PATCH] pg_ctl should not truncate command lines at 1024 characters Phil Krylov <phil@krylov.eu>
Re: [PATCH] pg_ctl should not truncate command lines at 1024 characters Tom Lane <tgl@sss.pgh.pa.us>
Re: [PATCH] pg_ctl should not truncate command lines at 1024 characters Phil Krylov <phil@krylov.eu>
Re: [PATCH] pg_ctl should not truncate command lines at 1024 characters Tom Lane <tgl@sss.pgh.pa.us>
Re: [PATCH] pg_ctl should not truncate command lines at 1024 characters Ranier Vilela <ranier.vf@gmail.com>
Re: [PATCH] pg_ctl should not truncate command lines at 1024 characters Phil Krylov <phil@krylov.eu>
Hello, Lacking a tool to edit postgresql.conf programmatically, people resort to passing cluster options on the command line. While passing all non-default options in this way may sound like an abuse of the feature, IMHO pg_ctl should not blindly truncate generated command lines at MAXPGPATH (1024 characters) and then run that, resulting in: /bin/sh: Syntax error: end of file unexpected (expecting word) pg_ctl: could not start server Examine the log output. The attached patch tries to fix it in the least intrusive way. While we're at it, is it supposed that pg_ctl is a very short-lived process and is therefore allowed to leak memory? I've noticed some places where I would like to add a free() call. -- Ph.
В списке pgsql-hackers по дате отправления