Re: silent data loss with ext4 / all current versions

Attached is v2 of the patch, that

(a) adds explicit fsync on the parent directory after all the rename()
     calls in timeline.c, xlog.c, xlogarchive.c and pgarch.c

(b) adds START/END_CRIT_SECTION around the new fsync_fname calls
     (except for those in timeline.c, as the START/END_CRIT_SECTION is
     not available there)

The patch is fairly trivial and I've done some rudimentary testing, but
I'm sure I haven't exercised all the modified paths.

regards
Tomas

--
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services