Re: Find Dialog in SQL box (Admin3)?

> Since the custom lexer isn't unicode clean, it's still commented out.
> Please fix it, using wxString::ToAscii and wxString::FromAscii.
> wxScintilla seems to use a mixture of ansi and unicode, not very
healthy...

Ok, I will make that change. Do you need a diff from the same version I
used before, or from what you just committed?

> There will always be one missing... :-)

Yeah, I simply added the ones I saw unhighlighted in my functions. There
more for sure.

> Please check if highlighting is there correct too.

I believe anything between \'...\' is highlighted as a string in the
custom lexer implementation.

> Do you miss regex?

No, I don't. :)


-----Original Message-----
From: Andreas Pflug [mailto:Andreas.Pflug@web.de]
Sent: Sunday, June 01, 2003 4:13 PM
To: Yurgis Baykshtis; pgadmin-hackers@postgresql.org
Subject: Re: [pgadmin-hackers] Find Dialog in SQL box (Admin3)?

Hi Yurgis,

I committed most of your work to cvs.

>Here is my contribution:
>
>1. Custom SQL lexer registered and implemented directly in ctlSQLBox
>class.
>
>
Since the custom lexer isn't unicode clean, it's still commented out.
Please fix it, using wxString::ToAscii and wxString::FromAscii.
wxScintilla seems to use a mixture of ansi and unicode, not very
healthy...

>I've done this to detect AS '....' construction.
>Everything inside quotes after AS will be highlighted as in regular SQL
>code. Escaped quotes (\') are also detected correctly.
>Now, the more preferable way to edit/update stored procedures will be
>using Query window (instead of Properties dialog). So, just select a
>function, click SQL on toolbar and edit the code. Once your change is
>ready just click "Play" and the procedure will updated in the DB. Way
>more convenient, isn't it?
>
I'd be working the same way, because I like to have stored my work into
files. There's still one advantage of using the properties dialog: There

are less quotes. Please check if highlighting is there correct too.

>2. More keywords added such as UNIUON, INNER, OUTER, etc.
>
There will always be one missing... :-)

>3. Find Dialog. Press Ctrl-F in any SQL box to activate Find dialog.
>No regular expressions though, since wx UI does not support that in its
>Find dialog. Custom Find dialog needs to be implemented for that.
>
Do you miss regex?

>
>4. Edit Menu in Query window. I also added Edit menu to the Query
>window.
>
Oops, that line got lost. We now also have a toolbar button for find.


Regards,
Andreas