> >> I still have an opinion that documentation should be more verbose, than
> >> your version, but I can accept your version.
> >
> > I am not sure that's necessary, pageinspect is for developers.
> >
> >> Who is going to add heap_page_item_attrs to your patch? me or you?
> >
> > I recall some parts of the code I still did not like much :) I'll grab
> > some room to have an extra look at it.
>
> I have added back heap_page_item_attrs the patch attached, fixing at
> the same time some typos found while looking again at the code. If you
> are fine with this version, let's have a committer look at it.
Everything seems to be ok. I've changed only one thing in your version
of the patch. I've renamed split_tuple_data to
tuple_data_split_internal, because when there are split_tuple_data and
tuple_data_split in the same file, nobody will guess what the difference
between these function and why are they named in such a strange way.
If it is ok, set proper status, and let commiter do his job :-)
--
Nikolay Shaplov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company