I wrote:
> I think you just need to follow the standard pattern:
Yeah, the attached is enough to silence it for me.
(But personally I'd add comments saying that the typedef
appears in thus-and-such header file; see examples in
our tree.)
regards, tom lane
diff --git a/src/common/jsonapi.c b/src/common/jsonapi.c
index 3d1bd37ac26..0bb46b43024 100644
--- a/src/common/jsonapi.c
+++ b/src/common/jsonapi.c
@@ -79,7 +79,7 @@ typedef enum
* and the token and value for scalars that need to be preserved
* across calls.
*/
-typedef struct JsonParserStack
+struct JsonParserStack
{
int stack_size;
char *prediction;
@@ -89,18 +89,18 @@ typedef struct JsonParserStack
bool *fnull;
JsonTokenType scalar_tok;
char *scalar_val;
-} JsonParserStack;
+};
/*
* struct containing state used when there is a possible partial token at the
* end of a json chunk when we are doing incremental parsing.
*/
-typedef struct JsonIncrementalState
+struct JsonIncrementalState
{
bool is_last_chunk;
bool partial_completed;
StringInfoData partial_token;
-} JsonIncrementalState;
+};
/*
* constants and macros used in the nonrecursive parser
diff --git a/src/common/parse_manifest.c b/src/common/parse_manifest.c
index 040c5597df4..f9c026a6369 100644
--- a/src/common/parse_manifest.c
+++ b/src/common/parse_manifest.c
@@ -91,12 +91,12 @@ typedef struct
char *manifest_checksum;
} JsonManifestParseState;
-typedef struct JsonManifestParseIncrementalState
+struct JsonManifestParseIncrementalState
{
JsonLexContext lex;
JsonSemAction sem;
pg_cryptohash_ctx *manifest_ctx;
-} JsonManifestParseIncrementalState;
+};
static JsonParseErrorType json_manifest_object_start(void *state);
static JsonParseErrorType json_manifest_object_end(void *state);