On 09/08/2015 02:58 PM, Stephen Frost wrote:
> * Andrew Dunstan (andrew@dunslane.net) wrote:
>> Improve logging of TAP tests.
> [...]
>
> This broke 'make check' for REL9_4_STABLE with --enable-tap-tests
> because it added a reference to 'with_temp_install' but didn't actually
> define it.
>
> The attached seems to fix it.
>
> Would be great to get feedback on it as I'm no Makefile expert (it took
> me far too long to run down what was happening and work out what seemed
> like the right fix..).
>
Seems OK to me from a quick look - I guess the proof of the pudding is
in the eating. Does every "make check" target that was working still
work? I assume so. It's interesting that nobody has noticed this for
about 6 weeks.
Our Makefiles do seem to have become fairly esoteric.
cheers
andrew