On 2015-07-31 03:03, Michael Paquier wrote:
> On Thu, Jul 30, 2015 at 10:58 PM, Petr Jelinek wrote:
>> On 2015-07-27 15:18, Michael Paquier wrote:
>>> Something also has not been discussed yet: what to do with new_version
>>> and old_version (the options of CreateExtensionStmt)? As of now if
>>> those options are defined they are not passed down to the parent
>>> extensions but shouldn't we raise an error if they are used in
>>> combination with CASCADE? In any case, I think that the behavior
>>> chosen should be documented.
>>>
>>
>> I don't see why we should raise error, they are used just for the top-level
>> extension and I think it makes sense that way. CASCADE documentation says
>> SCHEMA option is cascaded to required extensions, do we need to say
>> something more than that (ie explicitly saying that the old_version and
>> new_version aren't)?
>
> OK, let's do so then. I think that we should still document the fact
> that the old and new version strings and not passed to the parent
> extensions when cascade is used for clarity. Something like:
> "Other options are not recursively applied when the CASCASE clause is used."
>
> I have been through this patch one last time and changed the following:
> - Improved documentation: missing markups with <literal>, SCHEMA is a
> clause and not a parameter, added explanation that options other than
> SCHEMA are not applied recursively with CASCADE
> - Corrected .gitignore in test_extensions, log/ was missing.
> Those are minor things though, hence I just switched patch as "Ready
> for committer".
>
Yeah I agree with those changes, thanks for the review.
-- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training &
Services