Re: Improving test coverage of extensions with pg_dump

Поиск
Список
Период
Сортировка
От Andreas Karlsson
Тема Re: Improving test coverage of extensions with pg_dump
Дата
Msg-id 55B93D9F.7060709@proxel.se
обсуждение исходный текст
Ответ на Re: Improving test coverage of extensions with pg_dump  (Michael Paquier <michael.paquier@gmail.com>)
Ответы Re: Improving test coverage of extensions with pg_dump  (Michael Paquier <michael.paquier@gmail.com>)
Список pgsql-hackers
I have reviewed this patch and it compiles runs and the new test case 
passes. The code is also clean and the test seems like a useful 
regression test.

What I do not like though is how the path src/test/tables_fk/t/ tells us 
nothing about what features are of PostgreSQL are tested here. For this 
I personally prefer the earlier versions where I think that was clear.

Another though: would it be worthwhile to also add an assertion to check 
if the data really was restored properly or would that just be redundant 
code?

-- 
Andreas



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Merlin Moncure
Дата:
Сообщение: Re: dblink: add polymorphic functions.
Следующее
От: Joe Conway
Дата:
Сообщение: Re: more RLS oversights