On 07/29/2015 10:13 AM, Michael Paquier wrote:
> On Sat, Jul 25, 2015 at 10:54 PM, Michael Paquier
> <michael.paquier@gmail.com> wrote:
>> An updated patch is attached.
>
> Attached is v9, that fixes conflicts with 01f6bb4 and recent commits
> that added TAP tests in pg_basebackup series.
Thanks, committed with some more tweaking. Peter just added a
slurp_file() function to TestLib.pm, so I used that to replace the call
to 'cat' instead of my previous snippet. I also fixed the issue in the
pg_basebackup test, that LSN is not necessarily 8 characters long,
slightly differently. Calling pg_xlogfile_name seemed a bit indirect.
I expanded the documentation on how to download and install IPC::Run. I
instructed to add PERL5LIB to buildenv.pl, pointing it to the extracted
IPC-Run-0.94/lib directory. Your phrasing of "putting it into PERL5LIB"
was pretty vague, and in fact the PERL5LIB environment variable was
overwritten in vcregress.pl, so just setting the PERL5LIB variable
wouldn't have worked. I changed vcregress.pl to not do that.
I considered moving the instructions on downloading and installing
IPC::Run in the Requirements section, instead of the Running the
Regression Tests section. But there are additional instructions on
downloading and installing more dependencies in the Building the
Documentation section too. The other dependencies in the Requirements
section affect the built binaries. Well, except for the Diff utility.
We're not totally consistent, but I think it's OK as it is.
> Also I added an equivalent of --enable-tap-tests for this MSVC stuff,
> removed afterwards by Heikki. Do we want it or not?
On Unix, that option controls whether "make check-world" runs the TAP
tests, but there is no equivalent of "check-world" on Windows. Maybe
there should be, but as long as there isn't, the only thing that the
option did was to stop "vcregress tapcheck" from working, if didn't
enable it in the config file first. That seems silly, so I removed it.
We'll need it if we add an equivalent of "make check-world" to
vcregress, but let's cross that bridge when we get there.
- Heikki