On 06/07/2015 07:36, Fabien COELHO wrote:
>
>> I looked at this a bit and have a few comments:
>>
>> * I think it might be best to restrict the hint to appear only in the
>> case that the SQLSTATE is ERRCODE_UNDEFINED_TABLE. There are a lot of
>> possible failures here, and I'm not sure this hint is apropos for any
>> but that one.
>
> Hmmm... the likelyhood of another kind of error is small on:
>
> "select count(*) from pgbench_branches;"
>
> I think the only other possibility would be a permission issue.
>
>> * I really don't care for "HINT pgbench: " as that's got pretty much
>> nothing to do with any other message formatting we have anywhere,
>> least of all the existing hint-like messages in pgbench.
>
> It is kind of a copy of postgres hints, but not more than that:
>
> HINT: Consider increasing the configuration parameter "max_wal_size"
>
>> I've started a different thread at
>> http://www.postgresql.org/message-id/22280.1436139973@sss.pgh.pa.us to
>> discuss what the general message formatting in pgbench ought to be,
>> and probably this needs to wait for the outcome of that discussion.
>
> Yep.
>
>> * I'd be a bit inclined to reduce the message to something like
>> Perhaps you need to do initialization ("pgbench -i") in database "foo"
>> so that we can avoid the question of formatting of multi-sentence hints.
>
> Why not. This sentence hints at one possible error instead of two,
> though, but it may be enough.
>
Here's a v7 patch which display the hint only if SQLSTATE is
ERRCODE_UNDEFINED_TABLE and use the message Tom suggested, as there
wasn't any better suggestion or strong objection with it in the other
thread.
--
Julien Rouhaud
http://dalibo.com - http://dalibo.org