Re: BUG #12379: pgbench should hint to pgbench -i

On 22/05/2015 11:33, Fabien COELHO wrote:
>
>>> HINT:  is "foo" the right database? did you initialize first (pgbench
>>> -i)?
>>
>> I don't think there is precedent for spitting out "HINT:" in client code
>> (at least grep didn't find it).  So this message might look like it's
>> coming from the server, while it doesn't.
>
> Here is a v3, which makes it clearer that the hint comes from pgbench.
>
> HINT pgbench:  is "foo" the right database? did you initialize first (-i)?
>

Hello,

I've just reviewed this patch. First, I've attached a rebased version
(v4), as the v3 doesn't apply anymore.

The patch is pretty simple, so everything is ok.


But I've noticed that if you don't specify any database to pgbench, you
get an empty database information:

HINT pgbench:  is "" the right database? did you initialize
first (-i)?


This isn't related to this patch specifically, but it may be confusing
for users.  At least more than the other places it could already appear
(debug mode and failed connection attempt).

As the database name is optional, wouldn't it be better to fix this
behavior?

Regards.

--
Julien Rouhaud
http://dalibo.com - http://dalibo.org