On 2015-06-19 09:08, Brendan Jurd wrote:
> On Sun, 14 Jun 2015 at 20:44 Petr Jelinek <petr@2ndquadrant.com
> <mailto:petr@2ndquadrant.com>> wrote:
>
> looks like I omitted psql tab completion from the TABLESAMPLE patch. The
> attached patch adds it.
>
>
> Hi Petr,
>
> I'm doing an initial review of this patch.
Thanks
>
> With the patch applied, psql correctly offers a list of existing
> tablesample methods for completion whenever the previous word is
> 'TABLESAMPLE'. I did notice that the syntax of the TABLESAMPLE clause
> requires brackets after the method name, but the tab completion does not
> complete the opening bracket. Whereas, say, ALTER FUNCTION does. I
> think it would be convenient and user-friendly to complete the opening
> bracket -- it would make it perfectly clear that an argument is required
> for the syntax to be valid.
>
Agreed, here is updated version which does that.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services