On 2015/04/30 17:15, Etsuro Fujita wrote:
> On 2015/04/30 2:10, Robert Haas wrote:
>> On Mon, Apr 27, 2015 at 7:47 AM, Michael Paquier
>> <michael.paquier@gmail.com> wrote:
>>> Authorizing ALTER FOREIGN TABLE as query string that a FDW can use
>>> with IMPORT FOREIGN SCHEMA is a different feature than what is
>>> proposed in this patch, aka an option for postgres_fdw and meritates a
>>> discussion on its own because it impacts all the FDWs and not only
>>> postgres_fdw. Now, related to this patch, we could live without
>>> authorizing ALTER FOREIGN TABLE because CREATE FOREIGN TABLE does
>>> authorize the definition of CHECK constraints.
>>
>> I agree. I don't think there's a huge problem with allowing IMPORT
>> FOREIGN SCHEMA to return ALTER FOREIGN TABLE statements, but it
>> doesn't really seem to be necessary. I don't see why we can't just
>> declare the CHECK constraints in the CREATE FOREIGN TABLE statement
>> instead of adding more DDL.
>
> I think that it'd improve the convenience of an FDW developer writing
> ImportForeignSchema() to allow it to return ALTER FOREIGN TABLE (and
> perhaps DROP FOREIGN TABLE) as well, but I agree that that needs another
> discussion. So I'll leave that as is and update the patch as discussed
> above.
Done. Please find attached an updated version of the patch.
Best regards,
Etsuro Fujita