On 2015/04/27 15:51, Michael Paquier wrote:
> On Mon, Apr 27, 2015 at 3:15 PM, Etsuro Fujita
> <fujita.etsuro@lab.ntt.co.jp> wrote:
>> I noticed that there is no postgres_fdw option to control whether check
>> constraints on remote tables are included in the definitions of foreign
>> tables imported from a remote PG server when performing IMPORT FOREIGN
>> SCHEMA, while we now allow check constraints on foreign tables.
> I guess that the addition of this option makes sense, but I think that
> this patch is doing it wrong by using ALTER FOREIGN TABLE and by
> changing the queries authorized in ImportForeignSchema(). The point of
> IMPORT FOREIGN SCHEMA is to authorize only CREATE FOREIGN TABLE and
> not other types of queries, not to mention that CREATE FOREIGN TABLE
> supports the definitions of constraints at table and column-level.
I don't think so. IMO, I think it'd be more convenient and flexible to
allow ALTER FOREIGN TABLE for creating foreign table definitions during
ImportForeignSchema().
Thanks for the comment!
Best regards,
Etsuro Fujita