Re: TABLESAMPLE patch

On 19/04/15 01:24, Michael Paquier wrote:
> On Sat, Apr 18, 2015 at 8:38 PM, Michael Paquier
> <michael.paquier@gmail.com> wrote:
>> On Fri, Apr 17, 2015 at 10:54 PM, Petr Jelinek wrote:
>>> On 10/04/15 06:46, Michael Paquier wrote:
>>>> 13) Some regression tests with pg_tablesample_method would be welcome.
>>>
>>> Not sure what you mean by that.
>>
>> I meant a sanity check on pg_tablesample_method to be sure that
>> tsminit, tsmnextblock and tsmnexttuple are always defined as they are
>> mandatory functions. So the idea is to add a query like and and to be
>> sure that it returns no rows:
>> SELECT tsmname FROM pg_tablesample_method WHERE tsminit IS NOT NULL OR
>> tsmnextblock IS NOT NULL OR tsmnexttuple IS NOT NULL;
>
> Yesterday was a long day. I meant IS NULL and not IS NOT NULL, but I
> am sure you guessed it that way already..
>

Yes I guessed that and it's very reasonable request, I guess it should
look like the attached (I don't want to send new version of everything
just for this).

--
  Petr Jelinek                  http://www.2ndQuadrant.com/
  PostgreSQL Development, 24x7 Support, Training & Services