Re: What exactly is our CRC algorithm?

On 04/03/2015 05:28 AM, Abhijit Menon-Sen wrote:
> At 2015-04-03 00:33:10 +0300, hlinnaka@iki.fi wrote:
>>
>> I came up with the attached.
>
> I like it very much.
>
> src/port/Makefile has (note src/srv):
>
>      +# pg_crc32c_sse42.o and its _src.o version need CFLAGS_SSE42
>      +pg_crc32c_sse42.o: CFLAGS+=$(CFLAGS_SSE42)
>      +pg_crc32c_sse42_srv.o: CFLAGS+=$(CFLAGS_SSE42)
>
> Other than that, this looks great. Thank you.
>
>> BTW, we might want to move the "traditional" and "legacy" crc32
>> implementations out of src/common. They are only used in backend
>> code now.
>
> I agree.

Committed this now, after some further cleanup and reorganizing the 
autoconf stuff.

- Heikki